Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate 2830 allow null references in NetworkBehaviourReference and NetworkObjectReference #2874

Merged
merged 6 commits into from
Apr 5, 2024
Merged

chore: migrate 2830 allow null references in NetworkBehaviourReference and NetworkObjectReference #2874

merged 6 commits into from
Apr 5, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Apr 5, 2024 •
edited
Loading

This PR migrates #2830 to the public repository.

Changelog

  • Changed: NetworkObjectReference and NetworkBehaviourReference to allow null references when constructing and serializing.

Testing and Documentation

  • Includes integration tests.
  • No documentation changes or additions were necessary.

@NoelStephensUnity NoelStephensUnity mentioned this pull request Apr 5, 2024
Closed
@NoelStephensUnity
update and style
3a7a299 
Fixing some style issues along with property type issues.
@NoelStephensUnity
test
2ad3093 
Adding some generalized testing to validate both NetworkBehaviourReference and NetworkObjectReference can be created using a null and serialized when null.
@NoelStephensUnity
update
f8e4145 
Updating the changed description.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review April 5, 2024 20:18
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner April 5, 2024 20:18
@NoelStephensUnity NoelStephensUnity merged commit d90292d into develop Apr 5, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the chore/migrate-2830-allow-null-references branch April 5, 2024 21:06
This was referenced Apr 5, 2024
Merged
Closed
@NoelStephensUnity NoelStephensUnity mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadauxCat ShadauxCat ShadauxCat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoelStephensUnity @ShadauxCat @SimoGecko